QA Report

[code423n4]

Missing Doc Comments in function getBrige()

The parameter round is missing in doc comments for the function getBrige() at TokemakBribe.sol

Also consider add doc comments at
https://github.com/code-423n4/2022-02-redacted-cartel/blob/main/contracts/ThecosomataETH.sol

Doc comments will increase the readability of the code and will avoid other more high risk issues. For example in this contest I sent a medium severity issue related to the same parameter.

Poc

https://github.com/code-423n4/2022-02-redacted-cartel/blob/92c4d5810df7b9de15eae55dc7641c8b36cd799d/contracts/TokemakBribe.sol#L188-L204

    @notice Get bribe from BribeVault
    @param  proposal            address  Proposal
    @param  token               address  Token   @audit-issue   need to add round parameter and all thecosomata eth
    @return bribeToken          address  Token address
    @return bribeAmount         address  Token address
 */
function getBribe(
    address proposal,
    uint256 round,
    address token
) external view returns (address bribeToken, uint256 bribeAmount) {
    return
        IBribeVault(bribeVault).getBribe(
            generateBribeVaultIdentifier(proposal, round, token)
        );
}

Similar issues

code-423n4/2021-09-swivel-findings#71

[GalloDaSballo]

Finding is valid and well documented, but report quantity pales in comparison to some other submissions

[GalloDaSballo]

2/10

[GalloDaSballo]

With the added #104 am bumping to 3/10