QA Report

[code423n4]

1. Clarify costpershare comment

https://github.com/code-423n4/2022-03-prepo/blob/f63584133a0329781609e3f14c3004c1ca293e71/contracts/core/Collateral.sol#L85-L88

this implementation was use for whoever read the comment was clear, cause this was nothing to impacted with code but to make it more neat instead.

             /**
             * # of shares owed = amount deposited / cost per share, cost per
             * share = total supply / total value.
             */

and it can be changed into :

              /**
             * # shares owed = amount deposited / cost per share, 
             * cost per share = total supply / total value.
             */

2. Unused ReentrancyGuard in TokenShortToken.sol

https://github.com/code-423n4/2022-03-prepo/blob/main/contracts/core/LongShortToken.sol

that ReentrancyGuard is unused due to doesnt set in contract either so it can be removed or use them instead.

[ramenforbreakfast]

1. is a duplicate of QA Report #40
2. import LongShortToken is a duplicate of Gas Optimizations #5