Return Values Ignored

[code423n4]

Lines of code

https://github.com/code-423n4/2022-03-prepo/blob/f63584133a0329781609e3f14c3004c1ca293e71/contracts/core/PrePOMarket.sol#L121
https://github.com/code-423n4/2022-03-prepo/blob/f63584133a0329781609e3f14c3004c1ca293e71/contracts/core/PrePOMarket.sol#L123
https://github.com/code-423n4/2022-03-prepo/blob/f63584133a0329781609e3f14c3004c1ca293e71/contracts/core/PrePOMarket.sol#L168
https://github.com/code-423n4/2022-03-prepo/blob/f63584133a0329781609e3f14c3004c1ca293e71/contracts/core/PrePOMarket.sol#L170

Vulnerability details

Proof of Concept

PrePOMarket.mintLongShortTokens(uint256) (contracts/core/PrePOMarket.sol#101-128) ignores return value by _collateral.transferFrom(msg.sender,_treasury,_fee) (contracts/core/PrePOMarket.sol#121)
PrePOMarket.mintLongShortTokens(uint256) (contracts/core/PrePOMarket.sol#101-128) ignores return value by _collateral.transferFrom(msg.sender,address(this),_amount) (contracts/core/PrePOMarket.sol#123)
PrePOMarket.redeem(uint256,uint256) (contracts/core/PrePOMarket.sol#130-173) ignores return value by _collateral.transfer(_treasury,_fee) (contracts/core/PrePOMarket.sol#168)
PrePOMarket.redeem(uint256,uint256) (contracts/core/PrePOMarket.sol#130-173) ignores return value by _collateral.transfer(msg.sender,_collateralOwed) (contracts/core/PrePOMarket.sol#170)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#unchecked-transfer

Tools Used

slither

Recommended Mitigation Steps

validate return values

[ramenforbreakfast]

duplicate of #4 and not valid because Collateral contract inherits from OZ ERC20 which safely reverts upon failed operations.

[gzeoneth]

Agree with sponsor, downgrading to Low/QA. Dup #34. Closing in favor of warden's QA report #21