Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #59

Open
code423n4 opened this issue Mar 19, 2022 · 1 comment
Open

QA Report #59

code423n4 opened this issue Mar 19, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

QA

  • allowAccounts emits an AccountAllowed even if account is already allowed
  • Gas: DepositHook/WithdrawHook.hook never uses _initialAmount variable. Can be removed to save gas on calldata.
  • Gas: _floor/_ceilingValuation are never used and never updated. can be removed from storage to save gas, should just read from MarketCreated event as they are never updated.
@code423n4 code423n4 added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax bug Something isn't working labels Mar 19, 2022
code423n4 added a commit that referenced this issue Mar 19, 2022
@code423n4
cmichel issue #59
27ebeef
@ramenforbreakfast
Copy link
Collaborator

ramenforbreakfast commented Mar 23, 2022 •
edited
Loading

First issue is a duplicate of #14
Second issue is a duplicate of #5
Third issue is not an issue, we originally only emitted it via an event, but it was decided to keep it obtainable from the contract state.

@ramenforbreakfast ramenforbreakfast added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Mar 23, 2022
This was referenced Apr 3, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ramenforbreakfast @code423n4