Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #63

Open
code423n4 opened this issue Mar 19, 2022 · 1 comment
Open

QA Report #63

code423n4 opened this issue Mar 19, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

initialize() can be frontrun

The initialize() function of the deployed contracts isn't called within the same transaction according to the deployment scripts. Thus, someone could frontrun the initialize call forcing you to redeploy.

grep -n  "init" deploy/*.ts

PrePOMarketFactory doesn't initialize ReentrancyGuardUpgradeable

The PrePOMarketFactory.initialize() function doesn't initialize ReentrancyGuardUpgradeable.

https://github.com/code-423n4/2022-03-prepo/blob/main/contracts/core/PrePOMarketFactory.sol#L21

Add __ReentrancyGuard_init_unchained();
@code423n4 code423n4 added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax bug Something isn't working labels Mar 19, 2022
code423n4 added a commit that referenced this issue Mar 19, 2022
@code423n4
Ruhum issue #63
7e6d864
@ramenforbreakfast
Copy link
Collaborator

First claim is duplicate of #4
Second claim is duplicate of #14

@ramenforbreakfast ramenforbreakfast added the duplicate This issue or pull request already exists label Mar 23, 2022
This was referenced Apr 3, 2022
Closed
Closed
@gzeoneth gzeoneth removed the duplicate This issue or pull request already exists label Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ramenforbreakfast @code423n4 @gzeoneth