Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #9

Closed
code423n4 opened this issue Mar 17, 2022 · 2 comments
Closed

QA Report #9

code423n4 opened this issue Mar 17, 2022 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Missing Zero-address Validation

Description

Some addresses can be set to zero address which could result in unexpected behaviors.

Permalinks

https://github.com/code-423n4/2022-03-prepo/blob/f63584133a0329781609e3f14c3004c1ca293e71/contracts/core/PrePOMarket.sol#L175

Mitigation

Setters of address type parameters should include a zero-address validation.
@code423n4 code423n4 added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax bug Something isn't working labels Mar 17, 2022
code423n4 added a commit that referenced this issue Mar 17, 2022
@code423n4
Kenshin issue #9
56d9f93
@code423n4 code423n4 mentioned this issue Mar 19, 2022
Open
@ramenforbreakfast
Copy link
Collaborator

duplicate of #5

@ramenforbreakfast ramenforbreakfast added the duplicate This issue or pull request already exists label Mar 22, 2022
@gzeoneth
Copy link
Member

gzeoneth commented Apr 3, 2022

Duplicated QA Report #10

@gzeoneth gzeoneth closed this as completed Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ramenforbreakfast @code423n4 @gzeoneth