Gas Optimizations

[code423n4]

Gas : Global var updates code structure is unnecessarily big

updateGlobalVar

Instead of:

function updatePriceOracle(address _priceOracle) external onlyOwner {
        require(priceOracle != _priceOracle, 'UPO1');
        _updatePriceOracle(_priceOracle);
    }

    function _updatePriceOracle(address _priceOracle) internal {
        require(_priceOracle != address(0), 'IUPO1');

        priceOracle = _priceOracle;
        emit PriceOracleUpdated(_priceOracle);
    }

It could be:

function updatePriceOracle(address _priceOracle) external onlyOwner {
        require(priceOracle != _priceOracle, 'UPO1');
        require(_priceOracle != address(0), 'UPO2');
        priceOracle = _priceOracle;
        emit PriceOracleUpdated(_priceOracle);

    }

It was not specified how the contract size was fixed in the next release, so this might or might not apply.

[ritik99]

_updatePriceOracle is called during initialization as well, during which we do not need to perform the extra check that updatePriceOracle performs