Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #47

Open
code423n4 opened this issue Mar 31, 2022 · 1 comment
Open

Gas Optimizations #47

code423n4 opened this issue Mar 31, 2022 · 1 comment
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Use private variables to save gas

They can be declared private for gas savings, only creating view functions for external read.

Proof of Concept

https://github.com/sublime-finance/sublime-v1/blob/46536a6d25df4264c1b217bd3232af30355dcb95/contracts/PooledCreditLine/PooledCreditLine.sol#L34-L75

Recommendation

Declare these variables to private.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Mar 31, 2022
code423n4 added a commit that referenced this issue Mar 31, 2022
@code423n4
rayn issue #47
b2b7d8b
@ritik99
Copy link
Collaborator

ritik99 commented Apr 12, 2022

Suggestion is valid

@HardlyDifficult HardlyDifficult mentioned this issue Apr 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ritik99 @code423n4