New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #62

Open

code423n4 opened this issue Mar 31, 2022 · 1 comment

Labels

bug G (Gas Optimization)

Contributor

code423n4 commented Mar 31, 2022

Use seperate LimitsUpdated event

Instead of using the first event argument to store a string, use seperate event to track individual limit
https://github.com/sublime-finance/sublime-v1/blob/46536a6d25df4264c1b217bd3232af30355dcb95/contracts/PooledCreditLine/PooledCreditLine.sol#L233

Unnecessary safemath when div(SCALING_FACTOR)

https://github.com/sublime-finance/sublime-v1/blob/46536a6d25df4264c1b217bd3232af30355dcb95/contracts/PooledCreditLine/LenderPool.sol#L319

Check fromBalance != 0 then proceed without safemath

https://github.com/sublime-finance/sublime-v1/blob/46536a6d25df4264c1b217bd3232af30355dcb95/contracts/PooledCreditLine/LenderPool.sol#L707

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          gzeon issue #62

Collaborator

ritik99 commented Apr 12, 2022

All suggestions are valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment