QA Report #81
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
1)- __gap is defined as storage variable but never used, - In vToken.sol
https://github.com/code-423n4/2022-04-phuture/blob/594459d0865fb6603ba388b53f3f01648f5bb6fb/contracts/vToken.sol#L222
2)- As mentioned in github description of ManageIndexReweightingLogic.sol - This index reweighs manually by it's admin. shouldn't we put some modifier for reweight function! it is defined as external but as the users of protocol need not to call this function. adding some modifier could be a good practice.
https://github.com/code-423n4/2022-04-phuture/blob/594459d0865fb6603ba388b53f3f01648f5bb6fb/contracts/ManagedIndexReweightingLogic.sol#L28
similary here for TopNMarketCapReweightingLogic.sol
https://github.com/code-423n4/2022-04-phuture/blob/594459d0865fb6603ba388b53f3f01648f5bb6fb/contracts/TopNMarketCapReweightingLogic.sol#L30-L34
The text was updated successfully, but these errors were encountered: