Gas Optimizations

[code423n4]

Unnecessary constructor call

The ReentrancyGuard base contract takes no constructor arguments and can be omitted as a modifier for constructor:

constructor(
    IAToken _aToken,
    IRewardsController _rewardsController,
    IPoolAddressesProviderRegistry _poolAddressesProviderRegistry,
    string memory _name,
    string memory _symbol,
    uint8 decimals_,
    address _owner
  ) Ownable(_owner) ERC20(_name, _symbol) ReentrancyGuard() { ... }

Recommendation:

constructor(
    IAToken _aToken,
    IRewardsController _rewardsController,
    IPoolAddressesProviderRegistry _poolAddressesProviderRegistry,
    string memory _name,
    string memory _symbol,
    uint8 decimals_,
    address _owner
  ) Ownable(_owner) ERC20(_name, _symbol) { ... }

balanceOfToken can be declared as a view

The balanceOfToken function is read-only and can be declared as a view.

AaveV3YieldSource.sol#L212:

 function balanceOfToken(address _user) external override returns (uint256) {
    return _sharesToToken(balanceOf(_user));
  }

Recommendation:

 function balanceOfToken(address _user) external view override returns (uint256) {
    return _sharesToToken(balanceOf(_user));
  }

Note that this also declared incorrectly in the IYieldSource interface.

Unnecessary usage of SafeMath library

Solidity 0.8.0 introduced checked arithmetic by default, so the SafeMath library may safely be omitted.

Typo in natspec comment

inhereted should read inherited in the natspec comment on line 38.

[PierrickGT]

Unnecessary constructor call

This is false, the constructor from ReentrancyGuard sets _status = _NOT_ENTERED;
That being said, the ReentrancyGuard would still work properly since the default value of _status is 0, so different from 2.
As a best practice, it is best to initialize it.

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/security/ReentrancyGuard.sol#L40
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/14ca3aeb798d9b9be31df86ae7ef8b8f760caa4c/contracts/security/ReentrancyGuard.sol#L52

balanceOfToken can be declared as a view

Not possible since we inherit from the yield source interface.

Unnecessary usage of SafeMath library

Duplicate of: #11

Typo in natspec comment

Duplicate of: #22

[gititGoro]

Given the sponsor feedback, this is mostly a Gas optimization issue and has been relabelled.

[gititGoro]

Duplicate of #98

[JeeberC4]

Changing name to better reflect the judging outcome.