Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #81

Open
code423n4 opened this issue Apr 27, 2022 · 1 comment
Open

QA Report #81

code423n4 opened this issue Apr 27, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

Comments are incorrect in these lines
https://github.com/fei-protocol/flywheel-v2/blob/main/src/rewards/FlywheelGaugeRewards.sol#L102
https://github.com/fei-protocol/flywheel-v2/blob/main/src/rewards/FlywheelGaugeRewards.sol#L134

These comments describe a variable named nextCycle, while they should have describing the variable currentCycle. (the function above doesn't even have the variable nextCycle.)
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Apr 27, 2022
code423n4 added a commit that referenced this issue Apr 27, 2022
@code423n4
kebabsec issue #81
92ceda7
@thomas-waite thomas-waite added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Jul 14, 2022
@thomas-waite
Copy link
Collaborator

It's discussing cycles in general, not a specific one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomas-waite @code423n4