New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #164

Open

code423n4 opened this issue May 23, 2022 · 0 comments

Labels

bug G (Gas Optimization) sponsor acknowledged

Contributor

code423n4 commented May 23, 2022

Gas Optimization

remove usage of .add, .sub, .mul and .div
Since the contract is written with solidity 0.8, there's no need to use SafeMath library for basic operation + - * /.
don't read user balance in AuraClaimZap if Option.UseAllWalletFunds is false.
In contract AuraClaimZap, it currently read crvBalance and cvxBalance first and pass it into _claimExtras. But it's not really used if Option.UseAllWalletFund is false.

uint256 crvBalance = IERC20(crv).balanceOf(msg.sender);
uint256 cvxBalance = IERC20(cvx).balanceOf(msg.sender);

That being said, it would be better if the function don't read the balance if it won't be used in _claimExtras

The text was updated successfully, but these errors were encountered:

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          antonttc issue #164

258be1d

0xMaharishi added the sponsor acknowledged label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment