Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #217

Open
code423n4 opened this issue May 24, 2022 · 0 comments
Open

QA Report #217

code423n4 opened this issue May 24, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

AuraLocker.sol

Q/A L83 lockDuration value

Although this is explained into the audit repo, on the project documentation provided here there is not mention at all about the week 17 of the locking process.

Fix

Either making a comment on the contract near it explaining why there is one week more and also make this clear on the project documentation. If I will lock my tokens inside a contract I am going to need to know with certainty how much time they will be locked there. At the first inconsistency, potential users may flee.


AuraBalRewardPool.sol

Low L184 pendingPenalty may jam getReward function

If the penalties are not forwarded for a certain period of time and the accumulation rate of penalties is high, getReward function will revert.
Although this is an unlikely scenario, the difference between the rewards rewards[address] mapping and the pendingPenalty is how and who can make them fluctuate. There is one mapping for each address but only one pendingPenalty variable for the whole pool. If the users maliciously start to take profits in purpose to accumulate penalties just to break this, sticking up to the code this function once the penalites are accumulated will revert preventing everyone else to call this function.


ExtraRewardsDistributor.sol

Q/A L45 Typo in Comment

There is a Chet hebrew letter on the last character just after "token". Maybe a subliminal message of Chai (Life) in hebrew :)


BaseRewardPool4626.sol

Q/A L60 Return Value Ignored

Interface of IDeposit implements the deposit function with a boolean return. On this line, the boolean return is unchecked and afterwards the difference between after and before balances is checked in order to determine if the deposit went through.

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels May 24, 2022
code423n4 added a commit that referenced this issue May 24, 2022
@0xMaharishi 0xMaharishi added the invalid This doesn't seem right label May 27, 2022
@dmvt dmvt removed the invalid This doesn't seem right label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

3 participants