QA Report #218
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Low Risk Issues
AuraLocker.sol#L239
You marked the region as "ADMIN" at #L191 but this function doesn't have the "onlyOwner" modifier.
I think it's not dangerous because both variables are immutable but it would be good to write some comments if you don't add the modifier.
Non-critical Issues
Natspec incomplete
AuraBalRewardPool.sol#L62 => @param _startDelay
BoosterOwner.sol#L69 => @param _seal
CrvDepositor.sol#L47 => #param _daoOperator
Event should use indexed fields if there are three or more fields
AuraMerkleDrop.sol#L41
Booster.sol#L72
Booster.sol#L78
Booster.sol#L82
Booster.sol#L84
RewardFactory.sol#L32
Typo
I will mark incorrect parts with ""
Aura.sol#L114
// e.g. (new) amount = 1e19 * 950 / 500 = "19e17";
AuraClaimZap.sol#L37
AuraVestedEscrow.sol#L94
Booster.sol#L372
control the contract forever if you set an empty address by mistake.
Booster.sol#L128
You can add below line at #L130.
require(_owner != address(0), "0 address");
You can modify similarly with others also.
Booster.sol#L138
Booster.sol#L148
Booster.sol#L191
CrvDepositor.sol#L62
CrvDepositor.sol#L67
PoolManagerProxy.sol#L43
PoolManagerProxy.sol#L48
PoolManagerSecondaryProxy.sol#L58
PoolManagerSecondaryProxy.sol#L63
VoterProxy.sol#L73
The text was updated successfully, but these errors were encountered: