QA Report

[code423n4]

Missing inheritances

Details: Decoupling an interface from its implementation can cause technical drift and also unease 3rd party integrations with the code.

Slither detected the following missing inheritances:

• AuraBalRewardPool (contracts/AuraBalRewardPool.sol:23-221) should inherit from IRewardStaking (contracts/AuraLocker.sol#12-14)
• CrvDepositorWrapper (contracts/CrvDepositorWrapper.sol:104-142) should inherit from ICrvDepositor (contracts/AuraStakingProxy.sol#10-19)
• DepositToken (convex-platform/contracts/contracts/DepositToken.sol:17-59) should inherit from ITokenMinter (convex-platform/contracts/contracts/Interfaces.sol#91-94)
• ExtraRewardStashV3 (convex-platform/contracts/contracts/ExtraRewardStashV3.sol:25-222) should inherit from IStash (convex-platform/contracts/contracts/Interfaces.sol#78-83)
• RewardHook (convex-platform/contracts/contracts/RewardHook.sol:18-51) should inherit from IRewardHook (convex-platform/contracts/contracts/interfaces/IRewardHook.sol#5-8)
• StashFactoryV2 (convex-platform/contracts/contracts/StashFactoryV2.sol:16-104) should inherit from IStashFactory (convex-platform/contracts/contracts/Interfaces.sol#124-126)
• TokenFactory (convex-platform/contracts/contracts/TokenFactory.sol:17-48) should inherit from ITokenFactory (convex-platform/contracts/contracts/Interfaces.sol#128-130)
• cvxCrvToken (convex-platform/contracts/contracts/cCrv.sol:17-61) should inherit from ITokenMinter (convex-platform/contracts/contracts/Interfaces.sol#91-94)

Impact: Code QA

Missing event for critical operations

Details: Consider emitting an event for these critical parameter changes ****for off-chain monitoring:

• setOwner in PoolManagerProxy.sol (L43)
• setOperator in PoolManagerProxy.sol (L48)
• setOwner in PoolManagerSecondaryProxy.sol (L58)
• setOperator in PoolManagerSecondaryProxy.sol (L63)

Impact: Low risk

Name of contract is different from contract file name

Details: ArbitartorVault.sol should be ArbitratorVault.sol

Impact: Informational

Typos

• ammount should be amount in L117 of CrvDepositor.sol