QA Report #259
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Pragma version don't use chaort :
Aura.sol,AURaBalRewardPool.sol,AuraClaimZap.sol,AuraLocker.sol,AuraMerkleDrop.sol,AuraMath.sol,AuraMinter.sol,AuraPenaltyForwarder.sol,ClaimFeesHelper.sol,BalLiquidityProvider.sol,
Best practice because in development and testing you can use different versions and cause bugs
No check for address zero and can do some weird thing to the functionality and contract,function you can save gas because your using to storage mappings and you dont have to add it if you have zero address.
https://github.com/code-423n4/2022-05-aura/blob/ad1d090831a901193464b1ac92a523ab61e52f6d/contracts/ClaimFeesHelper.sol#L43
—----------------------------------------------------------------------------------
https://github.com/code-423n4/2022-05-aura/blob/a8758161373bc9c9ad2aec363b511afa3ed0613f/contracts/Aura.sol#L2
reentrancy checks and effects not implemented
https://github.com/code-423n4/2022-05-aura/blob/a8758161373bc9c9ad2aec363b511afa3ed0613f/contracts/Aura.sol#L74
Not found event spelled wrong
https://github.com/code-423n4/2022-05-aura/blob/a8758161373bc9c9ad2aec363b511afa3ed0613f/contracts/Aura.sol#L76
Typo:
https://github.com/code-423n4/2022-05-aura/blob/90e63758c023af079b5347a08b006ad0e0730ab3/contracts/AuraBalRewardPool.sol#L13
—--------------------------------------------------------
make:distributed
https://github.com/code-423n4/2022-05-aura/blob/a8758161373bc9c9ad2aec363b511afa3ed0613f/contracts/Aura.sol#L18
Initialise
make:initialize
https://github.com/code-423n4/2022-05-aura/blob/a8758161373bc9c9ad2aec363b511afa3ed0613f/contracts/Aura.sol#L56
https://github.com/code-423n4/2022-05-aura/blob/90e63758c023af079b5347a08b006ad0e0730ab3/contracts/AuraBalRewardPool.sol#L210
Make don’t
dont
https://github.com/code-423n4/2022-05-aura/blob/a8758161373bc9c9ad2aec363b511afa3ed0613f/contracts/Aura.sol#L96
Make: constructor
constructoor
https://github.com/code-423n4/2022-05-aura/blob/90e63758c023af079b5347a08b006ad0e0730ab3/contracts/AuraBalRewardPool.sol#L59
https://github.com/code-423n4/2022-05-aura/blob/1956bcf340ef48b4babff55f937ebcb4d3dbd1b3/contracts/CrvDepositorWrapper.sol#L73
The text was updated successfully, but these errors were encountered: