Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #259

Open
code423n4 opened this issue May 24, 2022 · 0 comments
Open

QA Report #259

code423n4 opened this issue May 24, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Pragma version don't use chaort :
Aura.sol,AURaBalRewardPool.sol,AuraClaimZap.sol,AuraLocker.sol,AuraMerkleDrop.sol,AuraMath.sol,AuraMinter.sol,AuraPenaltyForwarder.sol,ClaimFeesHelper.sol,BalLiquidityProvider.sol,

Best practice because in development and testing you can use different versions and cause bugs
No check for address zero and can do some weird thing to the functionality and contract,function you can save gas because your using to storage mappings and you dont have to add it if you have zero address.

https://github.com/code-423n4/2022-05-aura/blob/ad1d090831a901193464b1ac92a523ab61e52f6d/contracts/ClaimFeesHelper.sol#L43

—----------------------------------------------------------------------------------
https://github.com/code-423n4/2022-05-aura/blob/a8758161373bc9c9ad2aec363b511afa3ed0613f/contracts/Aura.sol#L2
reentrancy checks and effects not implemented
https://github.com/code-423n4/2022-05-aura/blob/a8758161373bc9c9ad2aec363b511afa3ed0613f/contracts/Aura.sol#L74
Not found event spelled wrong
https://github.com/code-423n4/2022-05-aura/blob/a8758161373bc9c9ad2aec363b511afa3ed0613f/contracts/Aura.sol#L76

Typo:
https://github.com/code-423n4/2022-05-aura/blob/90e63758c023af079b5347a08b006ad0e0730ab3/contracts/AuraBalRewardPool.sol#L13
—--------------------------------------------------------
make:distributed
https://github.com/code-423n4/2022-05-aura/blob/a8758161373bc9c9ad2aec363b511afa3ed0613f/contracts/Aura.sol#L18
Initialise
make:initialize
https://github.com/code-423n4/2022-05-aura/blob/a8758161373bc9c9ad2aec363b511afa3ed0613f/contracts/Aura.sol#L56
https://github.com/code-423n4/2022-05-aura/blob/90e63758c023af079b5347a08b006ad0e0730ab3/contracts/AuraBalRewardPool.sol#L210
Make don’t
dont
https://github.com/code-423n4/2022-05-aura/blob/a8758161373bc9c9ad2aec363b511afa3ed0613f/contracts/Aura.sol#L96
Make: constructor
constructoor
https://github.com/code-423n4/2022-05-aura/blob/90e63758c023af079b5347a08b006ad0e0730ab3/contracts/AuraBalRewardPool.sol#L59

https://github.com/code-423n4/2022-05-aura/blob/1956bcf340ef48b4babff55f937ebcb4d3dbd1b3/contracts/CrvDepositorWrapper.sol#L73

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels May 24, 2022
code423n4 added a commit that referenced this issue May 24, 2022
@0xMaharishi 0xMaharishi added the duplicate This issue or pull request already exists label May 28, 2022
@dmvt dmvt removed the duplicate This issue or pull request already exists label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

3 participants