QA Report

[code423n4]

Typos

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/Aura.sol#L18

 *          distirbuted along a supply curve (cliffs etc). Fork of ConvexToken.

Change distirbuted to distributed

The same typo (dont) occurs in all three lines below:

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/Aura.sol#L95

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraLocker.sol#L393

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/ExtraRewardStashV3.sol#L48

Example:

    //use mapping+array so that we dont have to loop check each time setToken is called

Change dont to do not or don't

The same typo (constructoor) occurs in both lines below:

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraBalRewardPool.sol#L55

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/ExtraRewardsDistributor.sol#L33

     * @dev Simple constructoor

Change constructoor to constructor

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraClaimZap.sol#L122

     * @param minAmountOut          The min amount out for crv:cvxCrv swaps if swapping. Set this to zero if you

Change crv:cvxCrv to crv: cvxCrv if that was what was intended

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraClaimZap.sol#L195

        //lock upto given amount of crv and stake

Change upto to up to

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraLocker.sol#L22

 * @dev     Invdividual and delegatee vote power lookups both use independent accounting mechanisms.

Change Invdividual to Individual

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraLocker.sol#L88

    //     Epochs contains only the tokens that were locked at that epoch, not a cumulative supply

Change contains to contain

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraLocker.sol#L418

                //each epoch over due increases reward

Change epoch over due to overdue epoch

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraLocker.sol#L672

                    //stop now as no futher checks matter

Change futher to further

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraVestedEscrow.sol#L94

     * @param _amount     Arrary of amount of rewardTokens to vest

Change Arrary to Array

The same typo (redeemption) occurs in both lines below:

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/interfaces/IERC4626.sol#L114

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/BaseRewardPool4626.sol#L193

Example:

    /// the effects of their redeemption at the current block,

Change redeemption to redemption

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/Booster.sol#L165

        //reward factory only allow this to be called once even if owner

Change allow to allows

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/Booster.sol#L372

     * @notice Shuts down the WHOLE SYSTEM by withdrawing all the LP tokens ot here and then allowing

Change ot to to

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/ArbitartorVault.sol#L13

 * @notice  Hold extra reward tokens on behalf of pools that have the same token as a reward (e.g. stkAAVE fro multiple aave pools)

Change fro to from

The same typo (separate) occurs in all three lines below:

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/BaseRewardPool.sol#L57

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/Booster.sol#L411

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/Booster.sol#L468

Example:

        //some gauges claim rewards when withdrawing, stash them in a seperate contract until next claim

Change seperate to separate

The same typo (Repsonsible) occurs in both lines below:

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/Booster.sol#L569

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/Booster.sol#L631

     *         Repsonsible for collecting the crv from gauge, and then redistributing to the correct place.

Change Repsonsible to Responsible

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/BoosterOwner.sol#L168

    //force shutdown the system after timer has expired

Change shutdown the to shutdown of the

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/ConvexMasterChef.sol#L55

    // Bonus muliplier for early cvx makers.

Change muliplier to multiplier

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/ConvexMasterChef.sol#L177

    // Update reward vairables for all pools. Be careful of gas spending!

Change vairables to variables

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/ConvexMasterChef.sol#L298

    // Safe cvx transfer function, just in case if rounding error causes pool to not have enough CVXs.

Change in case if to in the case that

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/CrvDepositor.sol#L117

        //increase ammount

Change ammount to amount

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/CrvDepositor.sol#L163

     *         the cvx reward contract isnt costly to claim rewards.

Change isnt to is not or isn't

The same typo (guage) or (guages) occurs in all four lines below:

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/ExtraRewardStashV3.sol#L19

 *            On the Curve Guage. This tells the Gauge where to send rewards. The Booster crafts the calldata for this

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/ExtraRewardStashV3.sol#L92

     *          Guage rewards are sent directly to this stash even though the Curve method claim_rewards

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/ExtraRewardStashV3.sol#L93

     *          is being called by the VoterProxy. This is because Curves guages have the ability to redirect

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/RewardFactory.sol#L18

 *          - BaseRewardPool handles CRV rewards for guages

Change Guage to Gauge and guages to gauges

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/ExtraRewardStashV3.sol#L99

        //this is updateable from v2 gauges now so must check each time.

Change updateable to updatable

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/ExtraRewardStashV3.sol#L23

 *          - v3.2: Move constuctor to init function for proxy creation

Change constuctor to constructor

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/PoolManagerSecondaryProxy.sol#L32

     * @param _owner Executoor

Change Executoor to Executor

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/PoolManagerSecondaryProxy.sol#L102

        //check that the pool as weight

Change as to has

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/VirtualBalanceRewardPool.sol#L163

     *          actually hold any staked tokens it just diributes reward tokens

Change diributes to distributes

Issue: Require error message is incorrect or confusing
Explanation: A require message should provide accurate information for users to understand reason for failure

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraPenaltyForwarder.sol#L52

        require(bal > 0, "!empty");

Change message to empty or no balance

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraVestedEscrow.sol#L66

        require(totalTime >= 16 weeks, "!short");

Change message to short or start to end time < 16 wks

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/BoosterOwner.sol#L185

        require(_to != booster, "!invalid target");

Change message to invalid target