New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #330

Open

code423n4 opened this issue May 25, 2022 · 0 comments

Labels

bug duplicate G (Gas Optimization)

Contributor

code423n4 commented May 25, 2022

Better use "!=" instead ">".

POC

https://github.com/code-423n4/2022-05-aura/blob/0001f78d35f7e45b5244e9cf00e4c323417166e7/contracts/Aura.sol#L68
https://github.com/code-423n4/2022-05-aura/blob/085f573756b132b2a5992c5aa5d7b907cd11c289/contracts/AuraBalRewardPool.sol#L157
https://github.com/code-423n4/2022-05-aura/blob/0001f78d35f7e45b5244e9cf00e4c323417166e7/contracts/AuraLocker.sol#L259

Impact

Save gas use "!=" instead ">"

Caching Array

POC

https://github.com/code-423n4/2022-05-aura/blob/0001f78d35f7e45b5244e9cf00e4c323417166e7/contracts/AuraClaimZap.sol#L138

Impact

Caching array lenght can save gas.
#Navigation
uint256 tokenRewardContractsLen = tokenRewardContracts.length;
....

Unused Import

POC

https://github.com/code-423n4/2022-05-aura/blob/0001f78d35f7e45b5244e9cf00e4c323417166e7/contracts/AuraMerkleDrop.sol#L8

Impact

Save gas if import didnt use in contract.

Not defining variable

POC

https://github.com/code-423n4/2022-05-aura/blob/0001f78d35f7e45b5244e9cf00e4c323417166e7/contracts/AuraLocker.sol#L657

Impact

Not defining "cutoffEpoch" can reduce gas cost

Navigation

in https://github.com/code-423n4/2022-05-aura/blob/0001f78d35f7e45b5244e9cf00e4c323417166e7/contracts/AuraLocker.sol#L669
if (lockEpoch < epochStart) {
if (lockEpoch > epochStart.sub(lockDuration)) {
amount = amount.add(locks[i - 1].amount);
} else {
.....

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          Randyyy issue #330

d8dcbeb

0xMaharishi added the duplicate label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment