Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #39

Open
code423n4 opened this issue May 14, 2022 · 1 comment
Open

QA Report #39

code423n4 opened this issue May 14, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Low Risk Findings

[QA-1] Use timelock modifier for setter functions

Timelock modifier is commonly used for storage variable setters that effects the contract logic. Consider adding timelocks on such setters.

    AuraLocker.solL#215
    AuraMerkleDrop.solL#104
    AuraStakingProxy.solL#99
    AuraStakingProxy.solL#127
    AuraStakingProxy.solL#146

[QA-2] It is better to do multiplications first and then divisions

You can get better precision "for free" by changing the multiplication and divisions order such that multiplications come first.

    CrvDepositorWrapper.solL#73
    AuraLocker.solL#162
    AuraLocker.solL#275
    AuraLocker.solL#327
    AuraLocker.solL#327

[QA-3] Two steps verification

Consider changing to two steps verification process of transferring privileges. Human mistakes can happen.

    AuraVestedEscrow.sol
    PoolManagerProxy.sol
    PoolManagerSecondaryProxy.sol

[QA-4] Use safe math for solidity version <8

You should use safe math for solidity version <8 since there is no default over/under flow check it those versions.

    BaseRewardPool4626.sol
    BoosterOwner.sol
    PoolManagerProxy.sol
    PoolManagerV3.sol
    ProxyFactory.sol
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels May 14, 2022
code423n4 added a commit that referenced this issue May 14, 2022
@code423n4
mics issue #39
7e6ef08
@0xMaharishi
Copy link

[QA-4] is valid here,

@0xMaharishi 0xMaharishi added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label May 25, 2022
This was referenced May 29, 2022
Merged
Open
@0xMaharishi 0xMaharishi added the resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @0xMaharishi