Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimization #42

Open
code423n4 opened this issue May 14, 2022 · 2 comments
Open

Gas Optimization #42

code423n4 opened this issue May 14, 2022 · 2 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

Gas Report

Table of content

Gas Optimizations

State variables that could be set immutable

You can set the following state variables to immutable and save gas:

Unnecessary equals boolean

Boolean variables can be checked within conditionals directly without the use of equality operators to true/false.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels May 14, 2022
code423n4 added a commit that referenced this issue May 14, 2022
@code423n4
bobirichman issue #42
fdbca42
@0xMaharishi 0xMaharishi added invalid This doesn't seem right sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue labels May 25, 2022
@0xMaharishi
Copy link

There are not sensible reports

@dmvt
Copy link
Collaborator

dmvt commented Jun 25, 2022

Neither of these can be made immutable, but the other reports are reasonable.
AuraBalRewardPool.sol: rewardPerTokenStored
AuraLocker.sol: rewardTokens

@dmvt dmvt removed the invalid This doesn't seem right label Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmvt @code423n4 @0xMaharishi