QA Report

[code423n4]

QA Report

Table of content

• QA Findings
  • Multiplications should come before divisions to improve precision
  • Missing two steps verification process
  • Missing fee parameter validation

QA Findings

Multiplications should come before divisions to improve precision

You loss precision because of doing divisions before the multiplication. If you change the order it will improve the precision at no cost.

• CrvDepositor.sol#L95
• AuraLocker.sol#L275
• AuraLocker.sol#L327
• AuraLocker.sol#L420
• AuraLocker.sol#L483

Missing two steps verification process

The process of transferring ownership is dangerous since typing the wrong address can lead to severe implications. It is better to have to steps verification process with set and claim functions to decrease the chances of human error.

• AuraStakingProxy.sol
• AuraVestedEscrow.sol
• Booster.sol
• CrvDepositor.sol
• VoterProxy.sol

Missing fee parameter validation

The fee parameter need to be validated since otherwise you may allow it to be 0 fee. And fee that is over 100% for example is also probably a mistake that can happen with the decimals.

• Booster.sol#L255
• BoosterOwner.sol#L127