Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #46

Closed
code423n4 opened this issue May 15, 2022 · 2 comments
Closed

Gas Optimizations #46

code423n4 opened this issue May 15, 2022 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

https://github.com/code-423n4/2022-05-aura/blob/main/convex-platform/contracts/contracts/VoterProxy.sol#L345

Function execute: No need to return success variable as it will always be true due to condition at VoterProxy.sol#L353

https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraVestedEscrow.sol#L179

Function _claim: No need to proceed if claimable=0. Return and not revert since cancel function is dependent on this function

if(claimable==0) return;
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels May 15, 2022
code423n4 added a commit that referenced this issue May 15, 2022
@code423n4
csanuragjain issue #46
084bdee
@0xMaharishi 0xMaharishi added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label May 25, 2022
@0xMaharishi
Copy link

super low value

@dmvt dmvt added the duplicate This issue or pull request already exists label Jun 25, 2022
@dmvt
Copy link
Collaborator

dmvt commented Jun 25, 2022 •
edited
Loading

Grouping this with the warden’s gas report, #129

@dmvt dmvt closed this as completed Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmvt @code423n4 @0xMaharishi