Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #146

Open
code423n4 opened this issue Jun 3, 2022 · 1 comment
Open

QA Report #146

code423n4 opened this issue Jun 3, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

N01 - Typos

protocol/contracts/BkdLocker.sol:173   * @dev This does not invlude the gov. tokens queued for withdrawal. // typo - include
protocol/contracts/tokenomics/FeeBurner.sol:29  event Burned(address targetLpToken, uint256 amountBurned); // Emmited after a successfull burn to target lp token //  typo - successful
protocol/contracts/tokenomics/FeeBurner.sol:84  // Transfering LP tokens back to sender // typo -Transferring

N02 - Open TODO

protocol/contracts/tokenomics/InflationManager.sol:532  //TOOD: See if this is still needed somewhere

N03 - More readable numbers

Numbers like 100000000 could be set 100_000_000 for more readability:

    uint256 private constant _CLIFF_SIZE = 100000 * 1e18; //new cliff every 100,000 tokens 
    uint256 private constant _CLIFF_COUNT = 1000; // 1,000 cliffs
    uint256 private constant _MAX_SUPPLY = 100000000 * 1e18; //100 mil max supply
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jun 3, 2022
code423n4 added a commit that referenced this issue Jun 3, 2022
@code423n4
sashik_eth issue #146
4de3ae3
@chase-manning chase-manning added sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) labels Jun 6, 2022
@GalloDaSballo
Copy link
Collaborator

Agree with 1 and 2, personal preference on 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @chase-manning @code423n4