Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #176

Open
code423n4 opened this issue Jun 3, 2022 · 2 comments
Open

QA Report #176

code423n4 opened this issue Jun 3, 2022 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Users are still able to stake even if the gauge is killed. This appears to be the intention of the smart contract but thought I would flag this. It would be relatively straightforward to implement a require prior to allowing a user to stake into a gauge. Similar to blinded auction from solidity docs https://docs.soliditylang.org/en/v0.8.14/solidity-by-example.html#id2. Except no need for timestamp check.

This logic is repeated in other places (i.e. KeeperGauge). Thanks!

https://github.com/code-423n4/2022-05-backd/blob/2a5664d35cde5b036074edef3c1369b984d10010/protocol/contracts/tokenomics/AmmGauge.sol#L49-L54

https://github.com/code-423n4/2022-05-backd/blob/2a5664d35cde5b036074edef3c1369b984d10010/protocol/contracts/tokenomics/AmmGauge.sol#L140-L143

https://github.com/code-423n4/2022-05-backd/blob/2a5664d35cde5b036074edef3c1369b984d10010/protocol/contracts/tokenomics/AmmGauge.sol#L104-L115
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jun 3, 2022
code423n4 added a commit that referenced this issue Jun 3, 2022
@code423n4
masterchief issue #176
b59493a
@chase-manning
Copy link
Collaborator

duplicate of #147

@chase-manning chase-manning added the duplicate This issue or pull request already exists label Jun 7, 2022
@GalloDaSballo
Copy link
Collaborator

Dup of #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@GalloDaSballo @chase-manning @code423n4 @liveactionllama