Gas Optimizations

[code423n4]

cache in variables instead of loading

description

The code can be optimized by minimising the number of SLOADs. SLOADs are expensive (100 gas) compared to MLOADs/MSTOREs (3 gas).

findings

array lengths should be cached

/2022-05-backd/protocol/contracts/access/RoleManager.sol
82: for (uint256 i; i < roles.length; i = i.uncheckedInc()) {

/2022-05-backd/protocol/contracts/RewardHandler.sol
42: for (uint256 i; i < pools.length; i = i.uncheckedInc()) {
259: for (uint256 i; i < actions.length; i = i.uncheckedInc()) {

/2022-05-backd/protocol/contracts/tokenomics/FeeBurner.sol
56: for (uint256 i; i < tokens_.length; i = i.uncheckedInc()) {

/2022-05-backd/protocol/contracts/tokenomics/InflationManager.sol
116: for (uint256 i; i < stakerVaults.length; i = i.uncheckedInc()) {

/2022-05-backd/protocol/contracts/tokenomics/VestedEscrow.sol
94: for (uint256 i; i < amounts.length; i = i.uncheckedInc()) {

use calldata instead of memory

description

Use calldata instead of memory for function parameters saves gas if the function argument is only read.

findings

/2022-05-backd/protocol/contracts/tokenomics/FeeBurner.sol
43: function burnToTarget(address[] memory tokens_, address targetLpToken_)

named returns and a return statement isn’t necessary

description

Removing unused named returns variables can reduce gas usage (MSTOREs/MLOADs) and improve code clarity. To save gas and improve code quality: consider using only one of those.

findings

/2022-05-backd/protocol/contracts/tokenomics/FeeBurner.sol
47: returns (uint256 received)

using prefix increments save gas

description

Prefix increments are cheaper than postfix increments,
eg ++i rather than i++

findings

/2022-05-backd/protocol/contracts/tokenomics/KeeperGauge.sol
98: epoch++;

use custom errors

description

use custom errors instead of revert strings

If the contract(s) in scope allow using Solidity >=0.8.4, consider using Custom Errors as they are more gas efficient while allowing developers to describe the error in detail using NatSpec.

findings

eg

/2022-05-backd/protocol/contracts/tokenomics/VestedEscrow.sol
82: require(!initializedSupply, "Supply already initialized once");

[GalloDaSballo]

cache in variables instead of loading

Saves 3 gas per instance
3 * 6 = 18

use calldata instead of memory

As with all other submissions, no math = 0 points

named returns and a return statement isn’t necessary

Should save 3 gas (MSTORE of 0 value)

using prefix increments save gas

Saves 5 gas

## use custom errors
No math = no points

Total Gas Saved
26