New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #5

Open

code423n4 opened this issue May 29, 2022 · 1 comment

Labels

bug G (Gas Optimization) resolved sponsor confirmed

Contributor

code423n4 commented May 29, 2022

https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/utils/Preparable.sol#L143

Function _setConfig: No need to set deadlines[key] = 0; as this was already done in _executeDeadline function

https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/tokenomics/Minter.sol#L218

Function _mint: Check that amount is not equal to zero

amount!=0

Note: do same for mintNonInflationTokens

https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/tokenomics/LpGauge.sol#L59

Function claimRewards: Since amount is uint type so amount cannot be <0. Change it to

if (amount == 0) return 0;

Note: Same need to be fixed for other Gauge like AMMGauge

https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/BkdLocker.sol#L214

Function claimFees: If claimable is zero, no need to go further

require(claimable!=0);

The text was updated successfully, but these errors were encountered:

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          csanuragjain issue #5

760e13d

code423n4 mentioned this issue

Gas Optimizations #127

Open

chase-manning added sponsor confirmed resolved labels

Collaborator

GalloDaSballo commented Jun 17, 2022

https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/utils/Preparable.sol#L143

Saves 100 gas

https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/tokenomics/Minter.sol#L218

Saves gas in the "bad path", I'd rather revert then

https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/tokenomics/LpGauge.sol#L59

Saves 3 gas, although maybe the optimizer may convert to a is_zero

https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/BkdLocker.sol#L214

Saves gas in the "bad path"

Total Gas Saved 103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment