QA Report #60
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
resolved
Finding has been patched by sponsor (sponsor pls link to PR containing fix)
sponsor confirmed
Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Comments
code423n4
added
bug
chase-manning
added
sponsor confirmed
|
I think the lack of validation findings have merit, however the Struct commend is not actionable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
L-1 Maybe should have address(0) checks to avoid having to redeploy contracts
https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/BkdLocker.sol#:~:text=rewardToken%20%3D%20_rewardToken%3B
L-2 Missing checks for address when assigning values to address state variables
https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/BkdLocker.sol#:~:text=rewardToken%20%3D%20newRewardToken%3B
N-1 Multiple
addresssmapping can be combined into a single mapping of an address to a struct.https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/BkdLocker.sol#:~:text=mapping(address,)%20public%20totalStashed%3B
N-2 Emit an event in setInflationRecipient()
The
setInflationRecipient()function is operated only by the governerance and should emit an event when the inflationrecipient is set for the first time or changes.https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/tokenomics/AmmConvexGauge.sol#:~:text=function%20setInflationRecipient(,%7D
The text was updated successfully, but these errors were encountered: