QA Report

[code423n4]

Gas optimization

File Cally.sol

Line 211,304,320,353:
Create a modifier to check vault type as best practice

Current code:
require(vaultId % 2 != 0, "Not vault type");

Suggestion:

modifier checkVault() public {
require(vaultId % 2 != 0, "Not vault type");
_;
}

Line 263,307,323,354(link to line/s):
Create a modifier to check owner of vault/option as best practice

Current code:
require(ownerOf(vaultId) != address(0), "Vault does not exist");

Suggestion:

modifier checkOwner(ownerId) public {
require(ownerOf(ownerId) != address(0), "Vault/Option does not exist");
_;
}