Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #18

Open
code423n4 opened this issue May 10, 2022 · 0 comments
Open

QA Report #18

code423n4 opened this issue May 10, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Critical function should emit events

Criticals functions setFee, withdrawProtocolFees, setVaultBeneficiary should emit events.

setFee
withdrawProtocolFees
setVaultBeneficiary

validate input feeRate_

It would be nice to the end user if function setFee have a validation for a maximum feeRate_
setFee
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels May 10, 2022
code423n4 added a commit that referenced this issue May 10, 2022
@code423n4
0x4non issue #18
eb4629d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4