OnlyOwner functions that make critical changes should have safeguards

[code423n4]

Lines of code

https://github.com/code-423n4/2022-05-cally/blob/main/contracts/src/Cally.sol#L117-L121
https://github.com/code-423n4/2022-05-cally/blob/main/contracts/src/Cally.sol#L283-L285

Vulnerability details

Impact

Admin can change the protocol fee anytime, to any value by calling setFee() function. Even if there is no bad intention, this can potentially be used to damage the reputation of the protocol.

Proof of Concept

Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.

Tools Used

Manual analysis

Recommended Mitigation Steps

• A timelock can be added for such critical changes which may effect user decisions.
• A hardcoded max fee limit can be defined and setFee() can check the new fee against max fee.

[outdoteth]

owner can change fee at any time; #47
owner can set fee greater than 100%: #48