Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #220

Open
code423n4 opened this issue May 14, 2022 · 2 comments
Open

QA Report #220

code423n4 opened this issue May 14, 2022 · 2 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

The codebase that was given for the audit is simple and generally gas efficient. There are several informational issues :
I1- There isn't full natspec documentation of functions in callyNFT.sol
I2-Not using safe transfer for ERC721 is considered bad practice if the receiver can be a contract. It's used to ensure the benefitiary contract is able to handle ERC721.

https://github.com/code-423n4/2022-05-cally/blob/1849f9ee12434038aa80753266ce6a2f2b082c59/contracts/src/Cally.sol#L199

https://github.com/code-423n4/2022-05-cally/blob/1849f9ee12434038aa80753266ce6a2f2b082c59/contracts/src/Cally.sol#L295

I3- The callyNFT doesn't comply with ERC721 standard. The function balanceOf will always return type(uint256).max to save gas but this may break interaction with other contracts that rely on balanceOf.

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels May 14, 2022
code423n4 added a commit that referenced this issue May 14, 2022
@outdoteth
Copy link
Collaborator

this can be bumped to be medium severity:
I2-Not using safe transfer for ERC721 is considered bad practice if the receiver can be a contract. It's used to ensure the benefitiary contract is able to handle ERC721: #38

@HardlyDifficult
Copy link
Collaborator

Per the C4 guidance "part of auditing is demonstrating proper theory of how an issue could be exploited" and that does not seem to be explored here as it was in the primary report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

3 participants