Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #267

Open
code423n4 opened this issue May 14, 2022 · 1 comment
Open

QA Report #267

code423n4 opened this issue May 14, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

QA (LOW & NON-CRITICAL)

  • At Cally.sol, CreateVault() function, it's required that the dutchAuctionStartingStrikeIndex should be less than the strikeOptions.length which has the maximum value of 6765 ether. However, it may be assumed that the contract should be answering the needs even in the worst bearish market conditions where the Eth price is extremely low. The team might consider to increase this highest value to answer the bearish market prices like Eth = 200$.

  • At Cally.sol, CreateVault() function, there is no address(0) check for token parameter.

  • block.timestamp is used on many places at the scoped contracts. However, this can be manipulated by malicious miners like the options can be shown as expired before the end of the auction.
    Reference

  • The contracts are not pausable. The team might consider to add a pause() function if any DoS is performed to the website or any unexpected events might occur while the usersare having disadventages of this.

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels May 14, 2022
code423n4 added a commit that referenced this issue May 14, 2022
@HardlyDifficult
Copy link
Collaborator

Merging with #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

2 participants