Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #291

Open
code423n4 opened this issue May 14, 2022 · 0 comments
Open

QA Report #291

code423n4 opened this issue May 14, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

##LOW

Title: vaultId 1 can't be created

https://github.com/code-423n4/2022-05-cally/blob/main/contracts/src/Cally.sol#L188-L189

Currently, vaultId is started by 3. By replacing L188 and 189 can make it start to create the vaultId by number 1 as vaultIndex initialized value.

        vaultId = vaultIndex; //@audit-info: Set vaultId first, then update vaultIndex
	vaultIndex += 2;
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels May 14, 2022
code423n4 added a commit that referenced this issue May 14, 2022
@code423n4
rfa issue #291
49a12bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4