Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded G -> M from 164 [1654114758938] #330

Closed
code423n4 opened this issue Jun 1, 2022 · 1 comment
Closed

Upgraded G -> M from 164 [1654114758938] #330

code423n4 opened this issue Jun 1, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge

Comments

@code423n4
Copy link
Contributor

code423n4 commented Jun 1, 2022

Judge has assessed an item in Issue #164 as Medium risk. The relevant finding follows:

File:Cally.sol#224
require(msg.value >= premium, "Incorrect ETH amount sent");
Using == operator is 3 gas cheaper than >=. This also keeps people from acedently overpaying when buying an option.

Summary
Implementing each of these would reduce the deploymnt cost from 5,431,682 to 5,387,621 and reduces buyOption from 75,765 to 75,013.

@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working upgraded by judge labels Jun 1, 2022
code423n4 added a commit that referenced this issue Jun 1, 2022
@HardlyDifficult HardlyDifficult added the duplicate This issue or pull request already exists label Jun 1, 2022
@HardlyDifficult
Copy link
Collaborator

Dupe of #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge
Projects
None yet
Development

No branches or pull requests

2 participants