Upgraded G -> M from 164 [1654114758938] #330
Labels
2 (Med Risk)
Assets not at direct risk, but function/availability of the protocol could be impacted or leak value
bug
Something isn't working
duplicate
This issue or pull request already exists
upgraded by judge
Judge has assessed an item in Issue #164 as Medium risk. The relevant finding follows:
File:Cally.sol#224
require(msg.value >= premium, "Incorrect ETH amount sent");
Using == operator is 3 gas cheaper than >=. This also keeps people from acedently overpaying when buying an option.
Summary
Implementing each of these would reduce the deploymnt cost from 5,431,682 to 5,387,621 and reduces buyOption from 75,765 to 75,013.
The text was updated successfully, but these errors were encountered: