Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Q -> M from 98 [1654475216526] #342

Closed
code423n4 opened this issue Jun 6, 2022 · 1 comment
Closed

Upgraded Q -> M from 98 [1654475216526] #342

code423n4 opened this issue Jun 6, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge

Comments

@code423n4
Copy link
Contributor

code423n4 commented Jun 6, 2022 •
edited by HardlyDifficult
Loading

Judge has assessed an item in Issue #98 as Medium risk. The relevant finding follows:

Set Limits on setFee()
A Malicious owner could set feeRate to = (100 * 1e18) / 100; which would give the entire value of an exercise() transaction to the protocol, create a limit on the fees the owner can set.

https://github.com/code-423n4/2022-05-cally/blob/1849f9ee12434038aa80753266ce6a2f2b082c59/contracts/src/Cally.sol#L119-L121
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working upgraded by judge labels Jun 6, 2022
code423n4 added a commit that referenced this issue Jun 6, 2022
@code423n4
Upgrade for Cityscape issue #342
44e3f19
@HardlyDifficult HardlyDifficult added the duplicate This issue or pull request already exists label Jun 6, 2022
@HardlyDifficult
Copy link
Collaborator

Dupe of #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HardlyDifficult @code423n4