Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Q -> H from 413 [1656340258153] #500

Closed
code423n4 opened this issue Jun 27, 2022 · 1 comment
Closed

Upgraded Q -> H from 413 [1656340258153] #500

code423n4 opened this issue Jun 27, 2022 · 1 comment
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists upgraded by judge

Comments

@code423n4
Copy link
Contributor

Judge has assessed an item in Issue #413 as High risk. The relevant finding follows:
@code423n4 code423n4 added 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working upgraded by judge labels Jun 27, 2022
code423n4 added a commit that referenced this issue Jun 27, 2022
@code423n4
Upgrade for sashik_eth issue #500
5b65e5e
@HickupHH3 HickupHH3 added the duplicate This issue or pull request already exists label Jun 27, 2022
@HickupHH3
Copy link
Collaborator

L05 - Drain bonus tokens
Since bonus tokens distribute each time users withdraw() their shares, there are possible situations when fee amount for withdrawal is less than value of bonus token distributed. It could lead to draining bonus tokens by malicious users which repeatedly deposit-withdraw their shares unlit it's profitably - leaving other shares holders without bonus tokens.

Consider distribution of bonus tokens based on shares holding time.

dup of #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists upgraded by judge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @HickupHH3