Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Q -> M from 413 [1656341455160] #502

Closed
code423n4 opened this issue Jun 27, 2022 · 1 comment
Closed

Upgraded Q -> M from 413 [1656341455160] #502

code423n4 opened this issue Jun 27, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge

Comments

@code423n4
Copy link
Contributor

Judge has assessed an item in Issue #413 as Medium risk. The relevant finding follows:

@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working upgraded by judge labels Jun 27, 2022
code423n4 added a commit that referenced this issue Jun 27, 2022
@HickupHH3
Copy link
Collaborator

L07 - Adding new bonus tokens could lead to Dos
Admin could only add new bonus tokens for withdrawers using function setBonusToken().

Withdraw transaction calling to distributeBonusTokenRewards() which could run out of gas if list of bonus tokens will be too big.
This would lead to the inability of users to withdraw their assets.

Consider adding a function that allows the admin to delete addresses from bonusTokens.

dup of #249

@HickupHH3 HickupHH3 added the duplicate This issue or pull request already exists label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge
Projects
None yet
Development

No branches or pull requests

2 participants