Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Q -> M from 207 [1656344600309] #507

Closed
code423n4 opened this issue Jun 27, 2022 · 1 comment
Closed

Upgraded Q -> M from 207 [1656344600309] #507

code423n4 opened this issue Jun 27, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge

Comments

@code423n4
Copy link
Contributor

Judge has assessed an item in Issue #207 as Medium risk. The relevant finding follows:
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working upgraded by judge labels Jun 27, 2022
code423n4 added a commit that referenced this issue Jun 27, 2022
@code423n4
Upgrade for shenwilly issue #507
a2ccde8
@HickupHH3
Copy link
Collaborator

  1. Unbounded iteration over bonusTokens array
    If the bonusTokens array grows big enough, the gas cost to execute distributeBonusTokenRewards could be higher than the block limit and the withdraw function is forever disabled.

Recommended Mitigation
Keep bonusTokens small by adding a hard limit or add a function to remove bonusTokens.

dup of #249

@HickupHH3 HickupHH3 added the duplicate This issue or pull request already exists label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @HickupHH3