Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #146

Open
code423n4 opened this issue Jul 2, 2022 · 1 comment
Open

QA Report #146

code423n4 opened this issue Jul 2, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Remove extra space

https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Comptroller.sol#L92
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/NoteInterest.sol#L100
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Treasury/TreasuryDelegator.sol#L12
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Stableswap/BaseV1-periphery.sol#L513
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Accountant/AccountantDelegate.sol#L17

Add space

in comment section:
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/CNote.sol#L57
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/CNote.sol#L99
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/CNote.sol#L121
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/CNote.sol#L125

Add space there to make (err != 0):
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/CNote.sol#L100

Remove extra tabulation

https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/NoteInterest.sol#L144
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Treasury/TreasuryDelegator.sol#L115

Missed comment:

https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Treasury/TreasuryDelegate.sol#L53
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jul 2, 2022
code423n4 added a commit that referenced this issue Jul 2, 2022
@code423n4
grGred issue #146
51e90d5
@GalloDaSballo
Copy link
Collaborator

Space + Tabulation

NC

Missed comment:

NC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GalloDaSballo @code423n4