Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #174

Open
code423n4 opened this issue Jul 2, 2022 · 1 comment
Open

QA Report #174

code423n4 opened this issue Jul 2, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Use prettier

Your code is not formatted properly, you should install and enforce prettier on all your contract files.

image

Incorrect comment

https://github.com/Plex-Engineer/manifest-v2/blob/f6ebfe679973edf4f64832e64480ff5250ef8486/contracts/Proposal-Store.sol#L8

// This is an evil token. Whenever an A -> B transfer is called, half of the amount goes to B
// and half to a predefined C
contract ProposalStore {
...
}

ProposalStore is not an evil token!

Remove hardhat/console.sol

It's not a good idea to have debugging code going to the production.

import "hardhat/console.sol";

In these files:

Remove console.log

It's not a good idea to have debugging code going to the production.

https://github.com/Plex-Engineer/lending-market-v2/blob/ea5840de72eab58bec837bb51986ac73712fcfde/contracts/Stableswap/BaseV1-core.sol#L207

console.log("tokenIn: ", tokenIn);
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jul 2, 2022
code423n4 added a commit that referenced this issue Jul 2, 2022
@GalloDaSballo
Copy link
Collaborator

GalloDaSballo commented Aug 13, 2022

Use prettier

R

Incorrect comment

NC

Remove hardhat/console.sol

R

Neat, would recommend using more professional language for the report

2R 1NC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

2 participants