QA Report

[code423n4]

#1 Modifier must be first
Impact
modifier must be first running first

Proof of Concept
https://github.com/code-423n4/2022-06-illuminate/blob/92cbb0724e594ce025d6b6ed050d3548a38c264b/marketplace/MarketPlace.sol#L247

https://github.com/code-423n4/2022-06-illuminate/blob/912be2a90ded4a557f121fe565d12ec48d0c4684/redeemer/Redeemer.sol#L300

https://github.com/code-423n4/2022-06-illuminate/blob/912be2a90ded4a557f121fe565d12ec48d0c4684/lender/Lender.sol#L741-L754

Tool Used
Manual review

Recommendation Mitigation Steps
move authorized modifier be first before other function.

#2 Missing define natspec param aave
Impact
lend function have natspec comment which is missing the avee function parameter. Issues with comments are low risk based on Code4rena risk categories.

Proof of Concept
https://github.com/code-423n4/2022-06-illuminate/blob/912be2a90ded4a557f121fe565d12ec48d0c4684/lender/Lender.sol#L536

Tool Used
Manual review

Recommended Mitigation Steps
Add natspec comments include avee parameter in lend function.

#3 Must be immutable

Impact
the swivelAddr, apwineAddr, and lender can't be initialized by constructor.

Proof of Concept
https://github.com/code-423n4/2022-06-illuminate/blob/912be2a90ded4a557f121fe565d12ec48d0c4684/redeemer/Redeemer.sol#L33

https://github.com/code-423n4/2022-06-illuminate/blob/912be2a90ded4a557f121fe565d12ec48d0c4684/redeemer/Redeemer.sol#L27

https://github.com/code-423n4/2022-06-illuminate/blob/912be2a90ded4a557f121fe565d12ec48d0c4684/redeemer/Redeemer.sol#L23

https://github.com/code-423n4/2022-06-illuminate/blob/912be2a90ded4a557f121fe565d12ec48d0c4684/lender/Lender.sol#L33

Tool Used
Manual review

Recommended Mitigation Steps
the state must add immutable because in the constructor parameter mention swivelAddr, apwineAddr, and lender to initialize. so i suggest to add immutable on it.

#4 Grammar
Impact
decrase readibility

Proof of Concept
https://github.com/code-423n4/2022-06-illuminate/blob/912be2a90ded4a557f121fe565d12ec48d0c4684/redeemer/Redeemer.sol#L299

https://github.com/code-423n4/2022-06-illuminate/blob/912be2a90ded4a557f121fe565d12ec48d0c4684/lender/Lender.sol#L740

https://github.com/code-423n4/2022-06-illuminate/blob/912be2a90ded4a557f121fe565d12ec48d0c4684/marketplace/MarketPlace.sol#L246

Tool Used
Manual Review

Recommendation Mitigation Steps
change from

/// @param a address that msg.sender must be to be authorized

to

/// @param a address that msg.sender must be authorized