Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #52

Open
code423n4 opened this issue Aug 1, 2022 · 3 comments
Open

QA Report #52

code423n4 opened this issue Aug 1, 2022 · 3 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

AxelarGasServiceProxy

  • L6 - The IUpgradable interface is imported but is never used.

DepositBase

  • L7 - The IWETH9 interface is imported but is never used.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Aug 1, 2022
code423n4 added a commit that referenced this issue Aug 1, 2022
@code423n4
fatherOfBlocks issue #52
6935349
@re1ro
Copy link
Member

re1ro commented Aug 5, 2022

Good spot. Was left over after some refactoring

@re1ro re1ro mentioned this issue Aug 5, 2022
Open
@re1ro re1ro added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Aug 23, 2022
@re1ro
Copy link
Member

re1ro commented Aug 23, 2022

Mitigated

axelarnetwork/axelar-cgp-solidity#135

@GalloDaSballo
Copy link
Collaborator

1 Valid Refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@re1ro @GalloDaSballo @code423n4