QA Report

[code423n4]

QA: MISSING SPDX LICENSE IDENTIFIER

The following contract files do not have a license identifier:

• BytesUtils.sol
• RRUtils.sol
• SHA1.sol
• Algorithm.sol
• Digest.sol
• ETHRegistrarController.sol
• IETHRegistrarController.sol
• StringUtils.sol
• IBaseRegistrar.sol
• ReverseRegistrar.sol
• IReverseRegistrar.sol
• IMetadataService.sol
• ENS.sol

Consider adding the SPDX License Identifier to those files and any other file where it is missing.

L: MISSING NATSPEC & UNRESOLVED TODO's

The majority of the code is well-commented. However, there are some places that are missing NATSPEC:

• ETHRegistrarController, NameWrapper: Those codebases completely lack from NATSPEC.
• ReverseRegistrar: There is no NATSPEC on the beginning explaining what these contracts are meant to do.
• DNSSECImp.sol Line 238: Has an open TODO.

Consider updating/adding the NATSPEC not only from the places mentioned, but also from any other places where it might be a lack of comments / bad placed comments in order to provide a higher quality codebase.

L: MISSING PRAGMA VERSION

The following file do not specify a pragma compiler version / range:

• IBaseRegistrar.sol

Please consider adding missing pragmas to this file and any other files that may have this missing.