Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #212

Open
code423n4 opened this issue Jul 19, 2022 · 0 comments
Open

QA Report #212

code423n4 opened this issue Jul 19, 2022 · 0 comments
Labels
bug Something isn't working old-submission-method QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Summary

We list 2 low-critical findings:

  • (Low) floating pragma
  • (Low) Open TODO

(Low) floating pragma

Impact

Floating pragma may cause unexpected compilation time behaviour and introduce unintended bugs.

Proof of Concept

dnssec-oracle/BytesUtils.sol
1:pragma solidity ^0.8.4;

dnssec-oracle/SHA1.sol
1:pragma solidity >=0.8.4;

dnssec-oracle/DNSSECImpl.sol
2:pragma solidity ^0.8.4;

dnssec-oracle/DNSSEC.sol
2:pragma solidity ^0.8.4;

dnssec-oracle/RRUtils.sol
1:pragma solidity ^0.8.4;

Recommended Mitigation Steps

Don't use ^, lock pragma to ensure compiler version. e.g. pragma solidity 0.8.4;

(Low) Open TODO

Impact

Open TODO should be resolved.

Proof of Concept

https://github.com/code-423n4/2022-07-ens/blob/main/contracts/dnssec-oracle/DNSSECImpl.sol#L238

        // TODO: Check key isn't expired, unless updating key itself

Recommended Mitigation Steps

Resolve the TODO.

@code423n4 code423n4 added bug Something isn't working old-submission-method QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jul 19, 2022
code423n4 added a commit that referenced this issue Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working old-submission-method QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

1 participant