Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Q -> M from 93 [1659526885300] #319

Closed
code423n4 opened this issue Aug 3, 2022 · 1 comment
Closed

Upgraded Q -> M from 93 [1659526885300] #319

code423n4 opened this issue Aug 3, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge Original issue severity upgraded from QA/Gas by judge

Comments

@code423n4
Copy link
Contributor

code423n4 commented Aug 3, 2022 •
edited by dmvt
Loading

Judge has assessed an item in Issue #93 as Medium risk. The relevant finding follows:

Use call instead of transfer
Contract
ETHRegistrarController.sol

Description
It was observed that withdraw function is using transfer function instead of call for transferring ether. This could become a problem if owner is contract and require more than 2300 gas (in which case transfer reverts)

Recommendation
Use call which does not have 2300 gas limitation
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working upgraded by judge Original issue severity upgraded from QA/Gas by judge labels Aug 3, 2022
code423n4 added a commit that referenced this issue Aug 3, 2022
@code423n4
Upgrade for csanuragjain issue #319
4cb823b
@dmvt
Copy link
Collaborator

dmvt commented Aug 3, 2022

duplicate of #133

@dmvt dmvt closed this as completed Aug 3, 2022
@dmvt dmvt added the duplicate This issue or pull request already exists label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge Original issue severity upgraded from QA/Gas by judge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmvt @code423n4