Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Q -> M from 182 [1664281111530] #325

Closed
code423n4 opened this issue Sep 27, 2022 · 1 comment
Closed

Upgraded Q -> M from 182 [1664281111530] #325

code423n4 opened this issue Sep 27, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge Original issue severity upgraded from QA/Gas by judge

Comments

@code423n4
Copy link
Contributor

code423n4 commented Sep 27, 2022 •
edited by dmvt
Loading

Judge has assessed an item in Issue #182 as Medium risk. The relevant finding follows:

L00: Usage of transfer to send eth

The transfer function has a fixed gas stipend of 2300. If a contract as well as EOA can call the function, it is advised to use call function instead of transfer.

Here are transfer function used in the ETHRegistrarController.sol:
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working upgraded by judge Original issue severity upgraded from QA/Gas by judge labels Sep 27, 2022
code423n4 added a commit that referenced this issue Sep 27, 2022
@code423n4
Upgrade for zzzitron issue #325
1594270
@dmvt
Copy link
Collaborator

dmvt commented Sep 27, 2022

Duplicate of #133

@dmvt dmvt marked this as a duplicate of #133 Sep 27, 2022
@dmvt dmvt closed this as completed Sep 27, 2022
@dmvt dmvt added the duplicate This issue or pull request already exists label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge Original issue severity upgraded from QA/Gas by judge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmvt @code423n4