Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #345

Open
code423n4 opened this issue Aug 17, 2022 · 1 comment
Open

QA Report #345

code423n4 opened this issue Aug 17, 2022 · 1 comment
Labels
bug Something isn't working high quality report QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Aug 17, 2022
code423n4 added a commit that referenced this issue Aug 17, 2022
@code423n4
brgltd issue #345
6f76791
code423n4 added a commit that referenced this issue Aug 17, 2022
@code423n4
brgltd data for issue #345
9582876
@gititGoro
Copy link
Collaborator

Well done! This was a no-frills, high quality report. The first issue isn't valid. If changefee is locked when paused, you may very well wish to change the timelock address in the event that the old one was compromised.

The third last one about 16 vs 32 bit was low impact and fairly finicky but I awarded points because it's not technically unhelpful.

@code423n4 code423n4 mentioned this issue Oct 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high quality report QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gititGoro @code423n4