Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Withdraw Function hasnt Timelock #410

Closed
code423n4 opened this issue Aug 27, 2022 · 1 comment
Closed

Withdraw Function hasnt Timelock #410

code423n4 opened this issue Aug 27, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working invalid This doesn't seem right sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-08-nounsdao/blob/c1c7c6201d0247f92472419ff657b570f9104565/contracts/governance/NounsDAOLogicV2.sol#L783-L792

Vulnerability details

Withdraw Function Timelock should be added, it is a very important criterion for investors.
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Aug 27, 2022
code423n4 added a commit that referenced this issue Aug 27, 2022
@code423n4
0xSmartContract issue #410
081460b
@Shungy
Copy link
Member

Shungy commented Aug 27, 2022

Docs mention it will be behind a timelock. https://github.com/nounsDAO/nouns-tech/blob/7f95c2a124948caa0ea79aa5ea2130e2915b0302/vote-refund/README.md?plain=1#L41

@Shungy Shungy mentioned this issue Aug 28, 2022
Closed
@solimander solimander added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Aug 28, 2022
@gzeoneth gzeoneth added the invalid This doesn't seem right label Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working invalid This doesn't seem right sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Shungy @code423n4 @solimander @gzeoneth