New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #146

Open

code423n4 opened this issue Aug 5, 2022 · 0 comments

Labels

bug G (Gas Optimization) valid

Contributor

code423n4 commented Aug 5, 2022

For HomeFiProxy and HomeFi a Transparent Proxy Pattern (TPP) has been used.
According to https://docs.openzeppelin.com/contracts/4.x/api/proxy#transparent-vs-uups an UUPS pattern is more efficient in terms of gas consumption during deployment

At https://github.com/code-423n4/2022-08-rigor/blob/5ab7ea84a1516cb726421ef690af5bc41029f88f/contracts/HomeFi.sol#L191 and many other places instead of require, the custom errors shall be used which are more gas efficient https://blog.soliditylang.org/2021/04/21/custom-errors/

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          PaludoX0 issue #146

74d5baf

jack-the-pug added the valid label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment